Re: Surprising behaviour of \set AUTOCOMMIT ON

From: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
To: "Rahila Syed" <rahilasyed90(at)gmail(dot)com>
Cc: "Rushabh Lathia" <rushabh(dot)lathia(at)gmail(dot)com>,"Robert Haas" <robertmhaas(at)gmail(dot)com>,"PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Surprising behaviour of \set AUTOCOMMIT ON
Date: 2016-09-03 11:00:09
Message-ID: 793934fa-62c4-42b7-878b-f93205d58722@mm
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Rahila Syed wrote:

> >Above error coming because in below code block change, you don't have
> check for
> >command (you should check opt0 for AUTOCOMMIT command)

> Corrected in the attached.

There are other values than ON: true/yes and theirs abbreviations,
the value 1, and anything that doesn't resolve to OFF is taken as ON.
ParseVariableBool() in commands.c already does the job of converting
these to bool, the new code should probably just call that function
instead of parsing the value itself.

Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2016-09-03 11:09:02 Re: Surprising behaviour of \set AUTOCOMMIT ON
Previous Message Petr Jelinek 2016-09-03 09:14:37 Re: Logical Replication WIP