Re: TRIGGER with WHEN clause

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: TRIGGER with WHEN clause
Date: 2009-11-20 20:41:45
Message-ID: 7935.1258749705@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> [ TRIGGER WHEN patch ]

Applied with assorted revisions. AFAICT the system column issue is only
a problem for NEW references in BEFORE triggers --- those columns do
read correctly in OLD, and all the time in AFTER triggers. I revised
the parsing logic to enforce that. The patch also missed establishing
dependencies for stuff referenced in the WHEN expression, and there were
a few other minor problems.

regards, tom lane

In response to

Responses

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Greg Smith 2009-11-22 06:53:33 CommitFest 2009-11: One week update
Previous Message Greg Smith 2009-11-20 05:22:14 peg: review tool review request

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-11-20 21:25:39 Re: Prettification versus dump safety
Previous Message Tom Lane 2009-11-20 20:38:12 pgsql: Add a WHEN clause to CREATE TRIGGER, allowing a boolean