Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
Date: 2021-11-27 01:55:17
Message-ID: 79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On November 26, 2021 5:53:31 PM PST, Andres Freund <andres(at)anarazel(dot)de> wrote:
>Hi,
>
>On November 26, 2021 7:24:15 AM PST, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>Fortunately, it seems to have been only a minor oversight.
>
Agreed.

I wonder if we should turn some of these ifdefs into something boiling down to if (0) { ifdef body}... No need to make it impossible for the compiler to help us in most of these cases...

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-11-27 22:31:24 pgsql: Update high level vacuumlazy.c comments.
Previous Message Alvaro Herrera 2021-11-26 20:09:23 pgsql: Harden be-gssapi-common.h for headerscheck

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2021-11-27 02:19:32 Re: Inconsistent results from seqscan and gist indexscan
Previous Message Thomas Munro 2021-11-27 01:47:01 Re: WIP: WAL prefetch (another approach)