| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, underdog(at)theori(dot)io |
| Subject: | Re: remove_useless_joins vs. bug #19560 |
| Date: | 2026-09-26 18:05:06 |
| Message-ID: | 79317.1790445906@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> security@ received a report about a regression in commit 2ebf25e. On
> 2026-09-12, I told the reporter that we handle defects in unreleased code as
> non-vulnerabilities and asked them to report it to pgsql-hackers. I didn't
> find that report, so I'm forwarding it here.
> ...
> The new SJE implementation groups the RTEs by physical relation OID without
> comparing their security qualifiers or permission identities.
Right. I think the appropriate fix is probably to require
that the checkAsUser values match in RTEs we want to combine.
If we do that, I'm not sure that we need to consider securityQuals
as such (but I've not tried it so maybe I'm missing something).
The code 2ebf25e7d removed doesn't appear to have any particular
consideration for either checkAsUser or securityQuals, so I wonder
how it worked before.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Manu | 2026-09-26 18:09:04 | Re: Extension security improvement: Add support for extensions with an owned schema |
| Previous Message | Noah Misch | 2026-09-26 17:44:57 | Re: remove_useless_joins vs. bug #19560 |