| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
| Date: | 2017-01-05 18:02:58 |
| Message-ID: | 7931.1483639378@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Not that you mention it, I think I mis-stated the problem in the
> commit message: the problem is not if the tranche is unregistered, but
> rather if it is registered but the pointer references an address that
> is no longer valid. Registering the tranche with a fixed string
> rather than a pointer into a DSM segment that can go away fixes that.
Got it. That's fine then, but perhaps the comment on
LWLockRegisterTranche needs to be reconsidered. It's not good enough for
the tranche name to be "backend lifetime", it has to be something valid in
other backends as well. That probably means either (1) compile-time
constant in the core backend (not loadable modules!) or (2) allocated in
the main shared-memory segment.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-05 18:09:32 | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
| Previous Message | Robert Haas | 2017-01-05 17:44:53 | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= | 2017-01-05 18:05:56 | Re: [PATCH] Add GUCs for predicate lock promotion thresholds |
| Previous Message | Robert Haas | 2017-01-05 17:50:48 | Re: GUC for cleanup indexes threshold. |