pg_verify_checksums review

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_verify_checksums review
Date: 2018-06-19 08:25:14
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

In looking over pg_verify_checksums I found a few small things that I think
would improve on it:

* pg_verify_checksums was placed in the Client Utils section in the docs.
Since it requries physical access to the cluster datafiles it seems to belong
in the Server Utils section.

* The -D option and supported environment variable wasn’t documented.

* Only -D is supported for specifying the data directory, but most all other
utilities also support --pgdata on top of -D. To present a consistent user
interface we should probably support --pgdata in pg_verify_checksums as well.

The latter is I assume too invasive as we are past the freeze, but the first
two docs patches would make sense in 11 IMO as they document whats in the tree.

The attached patches fixes the above mentioned things (I don’t have a docs
toolchain working right now so the docs patches are best effort).

cheers ./daniel

Attachment Content-Type Size
0001-Move-pg_verify_checksum-from-client-to-server-utils.patch application/octet-stream 1006 bytes
0002-Add-D-option-to-pg_verify_checksum-documentation.patch application/octet-stream 1.6 KB
0003-Add-pgdata-as-alias-for-D-for-consistency.patch application/octet-stream 3.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-06-19 08:33:49 Re: [HACKERS] GUC for cleanup indexes threshold.
Previous Message Amit Langote 2018-06-19 08:06:00 documenting forbidden expressions in column defaults