Re: Decoding of (nearly) empty transactions and regression tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Decoding of (nearly) empty transactions and regression tests
Date: 2014-06-29 14:36:22
Message-ID: 7913.1404052582@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> Solution I)
> Change ReorderBufferCommit() to not call the begin()/commit() callbacks
> if no change() callback has been called. Technically that's trivial, but
> I don't think that'd end up being a better behaviour.

> Solution II)
> Disable autovacuum/analyze for the tables in the regression tests. We
> test vacuum explicitly, so we wouldn't loose too much test coverage.

> Solution III)
> Mark transactions that happen purely internally as such, using a
> xl_xact_commit->xinfo flag. Not particularly pretty and the most
> invasive of the solutions.

> I'm favoring II) so far... Other opinions?

You mean disable autovac only in the contrib/test_decoding check run,
right? That's probably OK since it's tested in the main regression
runs.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-06-29 14:54:34 Re: PostgreSQL for VAX on NetBSD/OpenBSD
Previous Message Martin Husemann 2014-06-29 14:32:56 Re: PostgreSQL for VAX on NetBSD/OpenBSD