Re: [Commitfest 2022-07] Patch Triage: Waiting on Author

From: Jacob Champion <jchampion(at)timescale(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Commitfest 2022-07] Patch Triage: Waiting on Author
Date: 2022-08-01 16:30:39
Message-ID: 78c1b3a6-2aa8-679c-f33b-a84a0b6ca030@timescale.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8/1/22 08:51, Justin Pryzby wrote:
> @Jacob: Is there any reason why it's necessary to do anything at all ?
> Does something bad happen if the patches are left in the current CF ?
> Why make not let patch authors (re) submit the patch for review when they're
> ready? Someone went to the effort to move it to the current CF, even though the
> patch wasn't ready to be reviewed. It'd be less work and avoid the process of
> "moving patches to the next CF" even though (at least in this case) it maybe
> shouldn't have even been in the current CF.

Maybe this is something to look into once we've implemented some more of
the low-hanging usability features that people have asked for. But if we
started doing it now, I'd expect the CFM's job to simply change from
moving patches ahead to pinging people who have patches left behind,
asking them if they meant to move the patches forward. I'm not convinced
it'd be all that useful.

> Also, is there a place which lists all of an author's patches (current and
> historic)? I think people would be less adverse to having their patches closed
> if 1) they knew they could re-open them; and, 2) there were a list of patches
> and their disposition (not a separate list per commitfest, and not showing each
> patch duplicated for each CF that a patch was opened in).

This would be great to have. I have a patch in progress that introduces
a "deferred" group, to make it more obvious the difference between a
patch that has been Rejected and a patch that's simply Returned or
Moved. Your suggestion would dovetail nicely with that, to able to see
"all my deferred patches".

--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-08-01 16:33:52 Re: [Commitfest 2022-07] Patch Triage: Waiting on Author
Previous Message Önder Kalacı 2022-08-01 16:21:48 Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher