| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: AIX support - alignment issues |
| Date: | 2022-07-06 13:02:15 |
| Message-ID: | 7890936c-392b-91be-edac-b6d5a500e4b9@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.07.22 04:21, Thomas Munro wrote:
> /*
> * Do not try to collapse these into one "w+" mode file. Doesn't work on
> - * some platforms (eg, HPUX 10.20).
> + * some platforms.
> */
> termin = fopen("/dev/tty", "r");
> termout = fopen("/dev/tty", "w");
I don't know how /dev/tty behaves in detail under stdio. I think
removing this part of the comment might leave the impression that
attempting to use "w+" will never work, whereas the existing comment
appears to indicate that it was only very old platforms that had the
issue. If we don't have an immediate answer to that, I'd leave the
comment as is.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Orlov | 2022-07-06 13:05:03 | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Previous Message | Maxim Orlov | 2022-07-06 13:00:04 | Re: Custom tuplesorts for extensions |