| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Joachim Wieland <joe(at)mcknight(dot)de>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: patch for parallel pg_dump |
| Date: | 2012-04-03 15:38:20 |
| Message-ID: | 7883.1333467500@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Apr 3, 2012 at 10:40 AM, Joachim Wieland <joe(at)mcknight(dot)de> wrote:
>> I completely agree. Assertions helped a lot dealing with concurrent
>> code. How do you want to tackle this for now? Want me to create a
>> separate header pg_assert.h as part of my patch? Or is it okay to
>> factor it out later and include it from the general header then?
> I'll just go do it, barring objections.
If the necessary support code isn't going to be available *everywhere*,
it should not be in postgres.h. So I did not care for your proposal to
put it in dumputils.
Possibly we could move assert.c into src/port/ and make it part of
libpgport?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-04-03 15:49:44 | Re: invalid search_path complaints |
| Previous Message | Tom Lane | 2012-04-03 15:33:38 | Re: Speed dblink using alternate libpq tuple storage |