Re: Remove redundant MemoryContextSwith in BeginCopyFrom

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove redundant MemoryContextSwith in BeginCopyFrom
Date: 2022-01-20 00:50:31
Message-ID: 783920.1642639831@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Japin Li <japinli(at)hotmail(dot)com> writes:
> I see you have already push this patch on master (89f059bdf52), why not
> remove MemoryContextSwitchTo in the middle of BeginCopyTo in this commit?

That was a different suggestion from a different person, so I didn't
want to muddle the credit. Also, it requires a bit of testing,
while 89f059bdf52 was visibly perfectly safe.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2022-01-20 00:51:13 Re: Document atthasmissing default optimization avoids verification table scan
Previous Message Japin Li 2022-01-20 00:44:17 Re: Remove redundant MemoryContextSwith in BeginCopyFrom