Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add parallel-aware hash joins.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add parallel-aware hash joins.
Date: 2018-01-04 17:11:37
Message-ID: 7839.1515085897@sss.pgh.pa.us (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-committerspgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Jan 4, 2018 at 11:00 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Also, what the devil is happening on skink?

> So, skink is apparently dying during shutdown of a user-connected
> backend, and specifically the one that executed the 'tablespace' test.

Well, yeah, valgrind is burping: the postmaster log is full of

==10544== VALGRINDERROR-BEGIN
==10544== Syscall param epoll_pwait(sigmask) points to unaddressable byte(s)
==10544==    at 0x7011490: epoll_pwait (epoll_pwait.c:42)
==10544==    by 0x4BF40B: WaitEventSetWaitBlock (latch.c:1048)
==10544==    by 0x4BF40B: WaitEventSetWait (latch.c:1000)
==10544==    by 0x3C0B3B: secure_read (be-secure.c:166)
==10544==    by 0x3CCD9E: pq_recvbuf (pqcomm.c:963)
==10544==    by 0x3CDA07: pq_getbyte (pqcomm.c:1006)
==10544==    by 0x4E2A2D: SocketBackend (postgres.c:339)
==10544==    by 0x4E444E: ReadCommand (postgres.c:512)
==10544==    by 0x4E7588: PostgresMain (postgres.c:4085)
==10544==    by 0x4641D0: BackendRun (postmaster.c:4412)
==10544==    by 0x467308: BackendStartup (postmaster.c:4084)
==10544==    by 0x4675F7: ServerLoop (postmaster.c:1757)
==10544==    by 0x4689D4: PostmasterMain (postmaster.c:1365)
==10544==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==10544== 
==10544== VALGRINDERROR-END

But (a) this is happening in multiple branches, and (b) we've not
changed anything near that code in awhile.  I think something broke
in valgrind itself.

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2018-01-04 17:28:31
Subject: Re: heads up: Fix for intel hardware bug will lead to performance regressions
Previous:From: Robert HaasDate: 2018-01-04 17:00:58
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table

pgsql-committers by date

Next:From: Peter EisentrautDate: 2018-01-04 18:56:36
Subject: pgsql: Refactor channel binding code to fetch cbind_data only when nece
Previous:From: Robert HaasDate: 2018-01-04 16:59:09
Subject: Re: pgsql: Add parallel-aware hash joins.

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group