| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Asynchronous MergeAppend |
| Date: | 2026-02-12 07:08:45 |
| Message-ID: | 782a968c8e01ec6db3b2da2120adf73b@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alexander Pyhalov писал(а) 2025-12-30 22:04:
> Matheus Alcantara писал(а) 2025-12-30 18:04:
>> On Tue Dec 30, 2025 at 10:15 AM -03, Alexander Pyhalov wrote:
>>> Looks good. What do you think about
>>> classify_matching_subplans_common()?
>>> Should it stay where it is or should we hide it to
>>> src/include/executor/execAppend.h ?
>>>
>> Yeah, sounds better to me to move classify_matching_subplans_common to
>> execAppend.h since it very specific for the MergeAppend and Append
>> execution. I've declared the function as static inline on execAppend.h
>> but I'm not sure if it's the best approach.
>>
>> I've also wrote a proper commit message for this new version.
>
> Looks good to me.
Hi.
Rebased patches over fresh master.
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-mark_async_capable-subpath-should-match-subplan.patch | text/x-diff | 2.4 KB |
| v13-0002-MergeAppend-should-support-Async-Foreign-Scan-subpla.patch | text/x-diff | 50.3 KB |
| v13-0003-Common-infrastructure-to-MergeAppend-and-Append-node.patch | text/x-diff | 88.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aya Iwata (Fujitsu) | 2026-02-12 07:23:52 | RE: [WIP]Vertical Clustered Index (columnar store extension) - take2 |
| Previous Message | Shlok Kyal | 2026-02-12 06:58:28 | Re: Skipping schema changes in publication |