Re: [PATCH] Backport perl tests for pg_upgrade from 322becb60

Hello!

On 09.12.2022 08:19, Michael Paquier wrote:
> On Mon, Aug 01, 2022 at 01:02:21AM +0300, Anton A. Melnikov wrote:
>> As far as i understand from this thread: https://www.postgresql.org/message-id/flat/Yox1ME99GhAemMq1%40paquier.xyz,
>> the aim of the perl version for the pg_upgrade tests is to achieve equality of dumps for most cross-versions cases.
>> If so this is the significant improvement as previously in test.sh resulted dumps retained unequal and the user
>> was asked to eyeball them manually during cross upgrades between different major versions.
>> So, the backport of the perl tests also seems preferable to me.
>
> I don't really agree with that. These TAP tests are really new
> development, and it took a few tries to get them completely right
> (well, as much right as it holds for HEAD). If we were to backport
> any of this, there is a risk of introducing a bug in what we do with
> any of that, potentially hiding a issue critical related to
> pg_upgrade. That's not worth taking a risk for.
>
> Saying that, I agree that more needs to be done, but I would limit
> that only to HEAD and let it mature more into the tree in an
> incremental fashion.
> --

I have withdrawn the patch with the backport, but then the question is whether we
will make fixes in older test.sh tests seems to be remains open.
Will we fix it? Justin is not sure if anyone needs this:
https://www.postgresql.org/message-id/67b6b447-e9cb-ebde-4a6b-127aea7ca268%40inbox.ru

Also found that the test from older versions fails in the current master.

Proposed a fix in a new thread: https://www.postgresql.org/message-id/49f389ba-95ce-8a9b-09ae-f60650c0e7c7%40inbox.ru

Would be glad to any remarks.

With the best wishes,

--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company