Re: Privilege checks on array coercions

From: Jim Nasby <jim(at)nasby(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Privilege checks on array coercions
Date: 2017-03-23 23:29:54
Message-ID: 77b4041b-a4ea-6524-4c2d-b86f43fd1b3c@nasby.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/23/17 12:37 PM, Andres Freund wrote:
> On 2017-03-23 15:26:51 -0400, Tom Lane wrote:
>> There is a test in privileges.sql (currently lines 589-625 in
>> privileges.out) that seems to be dependent on the fact that the
>> ArrayCoerceExpr logic doesn't check for EXECUTE privilege on the
>> per-element type coercion function if it's dealing with a NULL input
>> array.
...
>> Does anyone want to defend this
>> privileges test case as testing for some behavior that users expect?
>
> Not me - that seems quite sensible to change.

I'd even argue that existing behavior is a bug.
--
Jim C. Nasby, Data Architect jim(at)nasby(dot)net
512.569.9461 (cell) http://jim.nasby.net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-03-23 23:32:28 Re: Logical replication existing data copy
Previous Message Mark Kirkwood 2017-03-23 23:14:25 Re: Logical replication existing data copy