| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new heapcheck contrib module |
| Date: | 2020-10-22 03:45:08 |
| Message-ID: | 77A60E99-6054-40FD-A5D6-769C287D4A0F@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 21, 2020, at 1:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> I was about to commit 0001, after making some cosmetic changes, when I
>> discovered that it won't link for me. I think there must be something
>> wrong with the NLS stuff. My version of 0001 is attached. The error I
>> got is:
>
> Well, the short answer would be "you need to add
>
> SHLIB_LINK += $(filter -lintl, $(LIBS))
>
> to the Makefile". However, I would vote against that, because in point
> of fact amcheck has no translation support, just like all our other
> contrib modules. What should likely happen instead is to rip out
> whatever code is overoptimistically expecting it needs to support
> translation.
Done that way in the attached, which also include Robert's changes from v19 he posted earlier today.
| Attachment | Content-Type | Size |
|---|---|---|
| v20-0001-Adding-function-verify_heapam-to-amcheck-module.patch | application/octet-stream | 84.0 KB |
| v20-0002-Adding-contrib-module-pg_amcheck.patch | application/octet-stream | 84.9 KB |
| v20-0003-Creating-non-throwing-interface-to-clog-and-slru.patch | application/octet-stream | 21.8 KB |
| v20-0004-Using-non-throwing-clog-interface-from-amcheck.patch | application/octet-stream | 10.0 KB |
| v20-0005-Adding-ACL-checks-for-verify_heapam.patch | application/octet-stream | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2020-10-22 04:12:33 | Re: A new function to wait for the backend exit after termination |
| Previous Message | Thomas Munro | 2020-10-22 03:35:27 | Re: [Patch] Optimize dropping of relation buffers using dlist |