Re: [HACKERS] Proposal: Local indexes for partitioned table

From: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Maksim Milyutin <milyutinma(at)gmail(dot)com>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
Date: 2018-01-19 13:47:48
Message-ID: 776a16c8-e0b4-f609-632a-961e3fe96f78@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Alvaro,

On 01/18/2018 04:43 PM, Alvaro Herrera wrote:
> Here's a patch to add pg_dump tests. This verifies that the
> CREATE INDEX on parent and partition appear, as well as ALTER INDEX ..
> ATTACH PARTITION.
>
> While doing this, I noticed a small bug: the ALTER INDEX would not be
> dumped when only one of the schemas are specified to pg_dump (schema of
> parent and schema of partition), but it would be if both were specified.
> This patch fixes that problem too. AFAICS the test is correct after
> that fix (ie. the "like" and "unlike" sets are correct now.)
>

I get

pg_restore: creating INDEX "pg_catalog.pg_authid_oid_index"
pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 5493; 1259 2677 INDEX
pg_authid_oid_index jpedersen
pg_restore: [archiver (db)] could not execute query: ERROR: permission
denied: "pg_authid" is a system catalog
Command was:
-- For binary upgrade, must preserve pg_class oids
SELECT
pg_catalog.binary_upgrade_set_next_index_pg_class_oid('2677'::pg_catalog.oid);

CREATE UNIQUE INDEX "pg_authid_oid_index" ON "pg_authid" USING "btree"
("oid");

during check-world.

Best regards,
Jesper

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2018-01-19 14:02:06 Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist
Previous Message Simon Riggs 2018-01-19 13:42:56 Re: [HACKERS] Transaction control in procedures