| From: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, "ashutosh(dot)bapat(dot)oss(at)gmail(dot)com" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Crashes on a partition whose concurrent detach never finished |
| Date: | 2026-11-12 05:36:14 |
| Message-ID: | 77656396-056d-41ac-a0f4-4c61bb849a30@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Nov12, 2026 at 12:44 PM shveta malik wrote:
> On Wed, Nov 11, 2026 at 8:04 PM Zhijie Hou <houzhijie22(at)gmail(dot)com> wrote:
> >
> > I'm helping to merge the changes into 0001 and preparing patches for
> > all branches, hoping to close this item soon.
> >
>
> Overall, the patches look good to me. Just a nit: the name "pub" looks
> very generic for a test spec shared by many permutations. Perhaps we
> can name it "pub_test_detach" or "pub_detach".
Thanks for reviewing.
Since there's only one publication in this file, I think the current
name is fine as we don't need to distinguish it from any other
publication. Similar names are also used in other tests.
--
Best Regards,
Zhijie Hou
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2026-11-12 05:59:24 | Re: Crashes on a partition whose concurrent detach never finished |
| Previous Message | Michael Paquier | 2026-11-12 05:23:33 | Re: Injection point: fix race condition between attach and cleanup |