| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "a(dot)lubennikova(at)postgrespro(dot)ru" <a(dot)lubennikova(at)postgrespro(dot)ru>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "matsumura(dot)ryo(at)fujitsu(dot)com" <matsumura(dot)ryo(at)fujitsu(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive status ".ready" files may be created too early |
| Date: | 2021-08-23 17:38:16 |
| Message-ID: | 7761DE50-BA35-4832-A988-698EDFFD9319@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/23/21, 10:31 AM, "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> On 2021-Aug-23, alvherre(at)alvh(dot)no-ip(dot)org wrote:
>
>> The only way .ready files are created is that XLogNotifyWrite() is
>> called. For regular WAL files during regular operation, that only
>> happens in XLogNotifyWriteSeg(). That, in turn, only happens in
>> NotifySegmentsReadyForArchive(). But if the system runs and never
>> writes WAL records that cross WAL boundaries, that function will see
>> that both earliestSegBoundary and latestSegBoundary are MaxXLogSegno,
>> and return without doing anything. So no segments will be notified.
>
> Nevermind -- I realized that all segments get registered, not just those
> for which we generate continuation records.
Ah, okay. BTW the other changes you mentioned made sense to me.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-08-23 17:49:07 | Re: .ready and .done files considered harmful |
| Previous Message | Mark Dilger | 2021-08-23 17:36:27 | Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers) |