| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Platon Pronko <platon7pronko(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Subject: | Re: very long record lines in expanded psql output |
| Date: | 2021-09-24 11:42:53 |
| Message-ID: | 775442a6-6176-bff6-20ce-22ba1688cb5e@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/24/21 12:49 AM, Platon Pronko wrote:
> On 2021-09-23 22:28, Andrew Dunstan wrote:
>>
>> 2. It would possibly be better to pass the relevant parts of the options
>> to print_aligned_vertical_line() rather than the whole options
>> structure. It feels odd to pass both that and opt_border.
>
> What do you think about doing it the other way around - passing only
> whole
> options structure? That way we will roll 4 parameters (opt_border,
> printTextFormat,
> and two xheader ones) into only one argument.
> This increases code coupling a bit, but I'm not sure if that's
> relevant here.
>
Sure, as long as it doesn't result in duplicated computation.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2021-09-24 12:35:43 | Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ... |
| Previous Message | Amul Sul | 2021-09-24 11:37:42 | Re: [Patch] ALTER SYSTEM READ ONLY |