Re: Use LN_S instead of "ln -s" in Makefile

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use LN_S instead of "ln -s" in Makefile
Date: 2020-02-15 14:58:22
Message-ID: 770eab6f-4d3f-147c-cae8-624e7c19bd50@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/15/20 1:57 AM, Tom Lane wrote:
> Hm. So, these oversights are certainly bugs in narrow terms. However,
> they've all been like that for a *long* time --- the three instances
> you found date to 2005, 2006, and 2008 according to "git blame".
> The complete lack of complaints shows that nobody cares. So I think
> a fairly strong case could be made for going the other way, ie
> s/$(LN_S)/ln -s/g and get rid of the configure-time cycles wasted in
> setting up that variable.

Here is a patch which does that.

Andreas

Attachment Content-Type Size
remove-ln_s.patch text/x-patch 7.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2020-02-15 17:51:05 Re: Parallel copy
Previous Message Amit Kapila 2020-02-15 12:32:06 Re: Parallel copy