| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Symbolic names for the values of typalign and typstorage |
| Date: | 2020-03-03 21:45:51 |
| Message-ID: | 7709.1583271951@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> On 2020-Mar-03, Tom Lane wrote:
>>> I realized that a possible compromise position is to have tupmacs.h
>>> include pg_type_d.h, not the whole pg_type.h header, thus dodging the
>>> indirect inclusions. That still brings in the type-OID macros, but
>>> it's a lot less header scope creep than I was first fearing.
>> WFM.
> OK, I'll look harder at doing it that way.
Yeah, that works out very nicely: there's now only one place besides
tupmacs.h that needs a new #include.
I did a little more polishing, and consider the attached committable,
unless anyone has objections.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| macros-for-alignment-and-storage-constants-2.patch | text/x-diff | 90.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-03-03 21:46:46 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | David Zhang | 2020-03-03 21:32:05 | Re: Fastpath while arranging the changes in LSN order in logical decoding |