| From: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
|---|---|
| To: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Speedup twophase transactions |
| Date: | 2016-03-18 16:50:54 |
| Message-ID: | 76CFF90D-BD2E-45B6-ACE2-474F6EA85902@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 11 Mar 2016, at 19:41, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> wrote:
>
Thanks for review, Jesper.
> Some comments:
>
> * The patch needs a rebase against the latest TwoPhaseFileHeader change
Done.
> * Rework the check.sh script into a TAP test case (src/test/recovery), as suggested by Alvaro and Michael down thread
Done. Originally I thought about reducing number of tests (11 right now), but now, after some debugging, I’m more convinced that it is better to include them all, as they are really testing different code paths.
> * Add documentation for RecoverPreparedFromXLOG
Done.
---
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| twophase_replay.v2.diff | application/octet-stream | 24.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-18 17:15:03 | Re: Parallel Aggregate |
| Previous Message | Robert Haas | 2016-03-18 16:46:12 | Re: Parallel Aggregate |