Re: Improve const use in zlib-using code

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tristan Partin <tristan(at)neon(dot)tech>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve const use in zlib-using code
Date: 2023-08-03 07:08:13
Message-ID: 7697cfc0-683a-0bbd-fc78-735646612428@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02.08.23 16:39, Tristan Partin wrote:
> I like the idea. Though the way you have it implemented at the moment
> seems like a trap in that any time zlib.h is included someone also has
> to remember to add this define. I would recommend adding the define to
> the build systems instead.

Ok, moved to c.h.

> Since you put in the work to find the version of zlib that added this,
> You might also want to add `required: '>= 1.2.5.2'` to the
> `dependency('zlib')` call in the main meson.build.

Well, it's not a hard requirement, so I think this is not necessary.

> I am wondering if we
> could remove the `z_streamp` check too. The version that it was added
> isn't obvious.

Yeah, that appears to be very obsolete. I have made an additional patch
to remove that.

Attachment Content-Type Size
v2-0001-Improve-const-use-in-zlib-using-code.patch text/plain 3.0 KB
v2-0002-Remove-check-for-z_streamp.patch text/plain 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2023-08-03 07:53:47 Re: Extract numeric filed in JSONB more effectively
Previous Message tender wang 2023-08-03 06:55:03 Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails