Re: file_fdw: Fix ANALYZE does not enforce REJECT_LIMIT with on_error 'ignore'

On 05/11/2026 16:24, Fujii Masao wrote:

> On Thu, Nov 5, 2026 at 9:40 AM Ayoub Kazar <ayoub(dot)kazar(at)data-bene(dot)io> wrote:
>> However, ANALYZE silently ignores reject_limit, skips all
>> malformed rows, and finishes with a NOTICE.
> Personally, I'd prefer to keep this behavior. Statistics based on valid rows
> are still useful even when the number of errors exceeds reject_limit.
> Queries may still succeed, for example, when using LIMIT, whereas
> aborting ANALYZE would leave the statistics outdated. So I think
> ANALYZE should continue to ignore reject_limit. Thought?
Yes, very reasonable.
The NOTICE itself also provides good info about what's going on, so
that's okay.
>
> If we agree, how about documenting this exception and adding a comment
> in file_acquire_sample_rows() explaining why reject_limit is not enforced?
Attached is v2 documenting this in file-fdw.sgml and adding a comment in
file_acquire_sample_rows().

Regards,
Ayoub Kazar