| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Memoize ANTI and SEMI JOIN inner |
| Date: | 2025-07-02 09:01:39 |
| Message-ID: | 765bd69e-c8a8-4349-a10f-b394331ddae6@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/7/2025 05:48, wenhui qiu wrote:
> HI
>
> > - if (!extra->inner_unique && (jointype == JOIN_SEMI ||
> > - jointype == JOIN_ANTI))
> > + if ((jointype == JOIN_SEMI || jointype == JOIN_ANTI) &&
> > + !extra->inner_unique)
> To be nitpicky, this change is meant to align with the earlier comment
> modifications to improve code readability, right? Everything else looks
> good to me."
Yep, I also found only this flaw.
Comments looks clear to me, test is quite stable.
May be correct the line:
INSERT INTO tab_anti SELECT i%3, false FROM generate_series(1,100)i;
with a backspace or an 'AS' keyword?
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-07-02 09:03:35 | Re: A assert failure when initdb with track_commit_timestamp=on |
| Previous Message | Eduard Stefes | 2025-07-02 08:27:46 | RE: [V2] Adding new CRC32C implementation for IBM S390X |