| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | 邱宇航 <iamqyh(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Transaction timeout |
| Date: | 2023-12-18 05:49:23 |
| Message-ID: | 76472EBA-077B-4F6D-B84D-F0917A31CEDD@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 16 Dec 2023, at 05:58, Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> On Fri, 15 Dec 2023 at 17:51, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>>> On 8 Dec 2023, at 15:29, Japin Li <japinli(at)hotmail(dot)com> wrote:
>>>
>>> Thanks for updating the patch. LGTM.
>>
>> PFA v9. Changes:
>> 1. Added tests for idle_in_transaction_timeout
>> 2. Suppress statement_timeout if it’s shorter than transaction_timeout
>>
> + if (StatementTimeout > 0
> + && IdleInTransactionSessionTimeout < TransactionTimeout)
> ^
>
> Should be StatementTimeout?
Yes, that’s an oversight. I’ve adjusted tests so they catch this problem.
> Maybe we should add documentation to describe this behavior.
I've added a paragraph about it to config.sgml, but I'm not sure about the comprehensiveness of the wording.
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Introduce-transaction_timeout.patch | application/octet-stream | 20.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-12-18 05:58:46 | Re: Fix a comment in basic_archive about NO_INSTALLCHECK |
| Previous Message | Bharath Rupireddy | 2023-12-18 05:39:41 | Re: Add a perl function in Cluster.pm to generate WAL |