Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet
Date: 2016-05-31 16:34:41
Message-ID: 7635.1464712481@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, May 26, 2016 at 3:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> 99% of the time, you'd be right. But this is an unusual case, for the
>> reasons I mentioned before.

> I tend to agree with Nikolay. I can't see much upside in making this
> change. At best, nothing will break. At worst, something will break.
> But how do we actually come out ahead?

We come out ahead by not having to make the documentation more confusing.

Basically, we have the opportunity to fix an ancient mistake here at
very low cost. I do not think that doubling down on the mistake is
a better answer.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-05-31 16:36:08 Re: parallel.c is not marked as test covered
Previous Message Robert Haas 2016-05-31 16:30:53 Re: [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet