| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgres_fdw: using TABLESAMPLE to collect remote sample |
| Date: | 2022-02-22 20:12:15 |
| Message-ID: | 76202fae-0c34-4f49-e3a0-1071c3fcf9e1@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/22/22 01:36, Fujii Masao wrote:
>
>
> On 2022/02/18 22:28, Tomas Vondra wrote:
>> Hi,
>>
>> here's a slightly updated version of the patch series.
>
> Thanks for updating the patches!
>
>
>> The 0001 part
>> adds tracking of server_version_num, so that it's possible to enable
>> other features depending on it.
>
> Like configure_remote_session() does, can't we use PQserverVersion()
> instead of implementing new function GetServerVersion()?
>
Ah! My knowledge of libpq is limited, so I wasn't sure this function
exists. It'll simplify the patch.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-02-22 20:16:41 | Re: [BUG] Panic due to incorrect missingContrecPtr after promotion |
| Previous Message | Andrew Dunstan | 2022-02-22 20:10:30 | Re: bailing out in tap tests nearly always a bad idea |