Re: pgsql: Refactor the sslfiles Makefile target for ease of use

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor the sslfiles Makefile target for ease of use
Date: 2021-10-27 14:37:45
Message-ID: 7614BC3D-0B3B-4D9C-8801-D771042EF2B4@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 26 Oct 2021, at 19:41, Andres Freund <andres(at)anarazel(dot)de> wrote:

> This fails during 'make clean' in a vpath build, because sslfiles.mk cannot be
> found. Probably just needs

It does in fact need that diff, but sslfiles.mk also needs to be taught about
the current $(srcdir) to properly function under VPATH for "make sslfiles".
Since it, by design, doesn't include Makefile.global it must be passed in
during invocation. Since you are the VPATH expert, does the attached look
sane? It passes for me locally but I almost never use VPATH to another set of
eyes would be good.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
0001-Fix-building-SSL-testfiles-in-VPATH-builds.patch application/octet-stream 5.0 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2021-10-27 15:12:23 Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
Previous Message Magnus Hagander 2021-10-27 14:30:41 pgsql: Clarify that --system reindexes system catalogs *only*