Re: Fix a failure of pg_dump with !HAVE_LIBZ

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix a failure of pg_dump with !HAVE_LIBZ
Date: 2016-05-26 15:54:35
Message-ID: 7601.1464278075@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> The warning says that it makes uncompressed archive but it really
> doesn't since workers die unexpectedly from the succeeding
> errors. This is because that compressLevel is corrected in
> ReadHead(), where too late for it to be propagated to workers.
> One reasonable place would be where the default value of
> compressLevel is set in main().

Yeah, agreed. I also noticed that you get the WARNING even when you
did not ask for compression, which seems rather unhelpful and annoying.
So I suppressed it by making the default be 0 not Z_DEFAULT_COMPRESSION
when we don't HAVE_LIBZ.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-05-26 15:57:00 Re: pg_dump -j against standbys
Previous Message Tom Lane 2016-05-26 15:11:11 Re: ORDER/GROUP BY expression not found in targetlist