RE: NaNs in numeric_power (was Re: Postgres 11 release notes)

From: Huong Dangminh <huo-dangminh(at)ys(dot)jp(dot)nec(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Akio Iwaasa <aki-iwaasa(at)vt(dot)jp(dot)nec(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: NaNs in numeric_power (was Re: Postgres 11 release notes)
Date: 2018-05-17 09:51:31
Message-ID: 75DB81BEEA95B445AE6D576A0A5C9E936A76D959@BPXM05GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

Hi,

> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> > On 16 May 2018 at 02:01, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I'm not particularly fussed about getting credit for that. However,
> >> looking again at how that patch series turned out --- ie, that we
> >> ensured POSIX behavior for NaNs only in HEAD --- I wonder whether we
> >> shouldn't do what was mentioned in the commit log for 6bdf1303, and
> >> teach numeric_pow() about these same special cases.
> >> It seems like it would be more consistent to change both functions
> >> for v11, rather than letting that other shoe drop in some future
> >> major release.
>
> > I'm inclined to agree. It's hard to imagine these two functions
> > behaving differently in regards to NaN input is useful to anyone.
>

Thank you. The patch looks fine to me.
Also, I have done the "make check" in Windows and Linux environment with no problem.

Thanks and best regards,
---
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-05-17 10:16:26 Re: overhead of expression evaluation
Previous Message Pavel Stehule 2018-05-17 09:32:16 overhead of expression evaluation

Browse pgsql-www by date

  From Date Subject
Next Message Michael Paquier 2018-05-17 12:48:54 Re: Postgres 11 release notes
Previous Message Amit Kapila 2018-05-17 02:27:47 Re: Postgres 11 release notes