RE: User defined data types in Logical Replication

From: Huong Dangminh <huo-dangminh(at)ys(dot)jp(dot)nec(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Hiroshi Yanagisawa <hir-yanagisawa(at)ut(dot)jp(dot)nec(dot)com>
Subject: RE: User defined data types in Logical Replication
Date: 2017-12-20 08:39:46
Message-ID: 75DB81BEEA95B445AE6D576A0A5C9E936A6DB28E@BPXM05GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Sawada-san,

> Thank you for quick response. The changes look good to me. But I wonder
> if the following changes needs some comments to describe what each checks
> does for.
>
> - if (errarg->attnum < 0)
> + if (errarg->local_attnum <0)
> + return;
> +
> + rel = errarg->rel;
> + remote_attnum = rel->attrmap[errarg->local_attnum];
> +
> + if (remote_attnum < 0)
> return;

Thanks, I have added some comments as you mentioned.

---
Thanks and best regards,
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

Attachment Content-Type Size
fix_slot_store_error_callback_v10.patch application/octet-stream 7.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2017-12-20 09:07:08 Re: Basebackups reported as idle
Previous Message Amit Kapila 2017-12-20 08:38:51 Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com