Re: Increase pltcl test coverage

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Karl Lehenbauer <karl(at)flightaware(dot)com>
Subject: Re: Increase pltcl test coverage
Date: 2017-01-08 00:13:31
Message-ID: 75932324-256d-6757-8e34-9dac69e3265a@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/6/17 2:17 PM, Tom Lane wrote:
> Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> writes:
>> On 10/31/16 3:24 PM, Jim Nasby wrote:
>>> This patch increases test coverage for pltcl, from 70% to 83%. Aside
>>> from that, the work on this uncovered 2 new bugs (the trigger return one
>>> I just submitted, as well as a bug in the SRF/composite patch).
>
>> Rebased patch attached. Test coverage is now at 85% (by line count).
>
> This is in a format that neither patch(1) nor "git apply" recognize.
> Please resubmit in a more usual format, diff -c or diff -u perhaps.

Odd, dunno what happened there. New patch attached.

BTW, this also includes some case changes back to lowercase. My muscle
memory would prefer to go the other direction but I figured consistency
was worth something. Feel free not to include that bit if you want.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)

Attachment Content-Type Size
pltcl_coverage_2.patch text/plain 29.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2017-01-08 00:45:30 Re: increasing the default WAL segment size
Previous Message Bruce Momjian 2017-01-07 23:46:55 Re: proposal: session server side variables (fwd)