Bruce Momjian <bruce(at)momjian(dot)us> writes:
> OK, I used your idea for conversion directly to oid from the system
> catalogs, patch attached. All the pg_controldata returned integers are
> defined as uint32 in pg_upgrade. Should I use atooid() for some of them
> and define some of them as OID?
No, I don't think so --- most of them are not in fact OIDs. Probably
best to follow what pg_control.h declares them as.
regards, tom lane