| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tighten up a few overly lax regexes in pg_dump's tap tests |
| Date: | 2019-02-06 09:50:27 |
| Message-ID: | 7555CA46-012B-44A3-9BC8-AF5DCB1A79BF@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Feb 2019, at 09:39, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> And done after checking the whole set.
I still think we should enforce one-or-more matching on the OWNER part as well,
since matching zero would be a syntax error. There are more .* matches but
I’ve only touched the ones which match SQL, since there is a defined grammar to
rely on there. The attached patch does that on top of your commit.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump_testregex.patch | application/octet-stream | 6.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-02-06 09:59:27 | Re: Bogus lateral-reference-propagation logic in create_lateral_join_info |
| Previous Message | Thomas Munro | 2019-02-06 09:40:25 | Re: pg11.1: dsa_area could not attach to segment |