Re: Test timings are increasing too fast for cfbot

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: Test timings are increasing too fast for cfbot
Date: 2026-03-25 14:38:01
Message-ID: 753e7734-95d9-45d3-85d9-a53638b1b3dd@vondra.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/25/26 04:15, Andres Freund wrote:
> ...
>
> The slowest test is stats_ext.sql - Not surprising, it does sequential scans
> of tables with ~1000-10000 rows over and over again. I don't see why it has
> to do that with as many rows as it does.
>

IIRC we needed to use non-trivial amounts of data to ensure building the
right right type of statistics (e.g. no MCV). But I understand it can be
annoyingly expensive, so I'll try to make it cheaper.

> ...
> 2) AssertCheckRanges() (only in the brin test, but there a very large portion
> of the runtime)

True. It is a very comprehensive validation of the ranges, and it was
very useful - particularly during development. But I'll try to make it
more targeted at the stuff actually changed / called less often.

Both changes will require time (so that we don't lose test coverage),
but I assume it's OK if that happens sometime after the feature freeze.

regards

--
Tomas Vondra

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2026-03-25 14:40:23 Re: Use CASEFOLD() internally rather than LOWER()
Previous Message Dave Cramer 2026-03-25 14:34:42 Re: Proposal to allow setting cursor options on Portals