Re: Adding REPACK [concurrently]

Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:

> On 2025-Sep-26, Mihail Nikalayeu wrote:
>
> > Should we rename it to repack_context to be aligned with the calling side?
>
> Sure, done.
>
> > > cmd == REPACK_COMMAND_CLUSTER ? "CLUSTER" : "REPACK",
> >
> > May be changed to RepackCommandAsString
>
> Oh, of course.
>
> > Documentation of pg_repackdb contains a lot of "analyze" and even
> > "--analyze" parameter - but I can't see anything related in the code.
>
> Hmm, yeah, that was missing. I added it. In doing so I noticed that
> because vacuumdb allows a column list to be given, then we should do
> likewise here, both in pg_repackdb and in the REPACK command, so I added
> support for that.

+ /*
+ * Make sure ANALYZE is specified if a column list is present.
+ */
+ if ((params->options & CLUOPT_ANALYZE) == 0 && stmt->relation->va_cols != NIL)
+ ereport(ERROR,
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+ errmsg("ANALYZE option must be specified when a column list is provided")));

Shouldn't the user documentation mention this restriction?

--
Antonin Houska
Web: https://www.cybertec-postgresql.com