Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)
Date: 2017-04-08 10:33:41
Message-ID: 7515b86e-575e-11a0-f3a0-e0bd69c3ec55@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 04/08/2017 04:23 AM, Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
>> Use SASLprep to normalize passwords for SCRAM authentication.
>
> The test script that this adds appears to fail unless the environment
> selects a UTF8-based locale. On my RHEL6 machine, I see:
>
> LANG=C make check fail
> LANG=en_US.iso88591 make check fail
> LANG=en_US.utf8 make check ok

Fixed, thanks!

> I'm surprised that more of the buildfarm hasn't fallen over.

Hmm. It looks like none of the buildfarm members are running the
authentication tests. Nor recovery tests, nor subscription tests. We're
missing a trick here, at least some of the buildfarm members really
ought to run "make check-world", we're missing a lot of coverage otherwise.

- Heikki

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2017-04-08 14:01:06 Re: Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)
Previous Message Heikki Linnakangas 2017-04-08 10:33:08 pgsql: Fix the new SASLprep tests to work with non-UTF-8 locales.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2017-04-08 10:39:16 Re: [pgsql-www] Small issue in online devel documentation build
Previous Message Fabien COELHO 2017-04-08 10:33:15 Re: [HACKERS] Small issue in online devel documentation build