Re: Installation instructions update (pg_ctl)

On 30.10.18 14:52, Andreas 'ads' Scherbaum wrote:
> On 30.10.18 09:04, Michael Banck wrote:
>> Hi,
>>
>> On Tue, Oct 30, 2018 at 12:08:49AM +0100, Andreas 'ads' Scherbaum wrote:
>>> The installation instructions (short version) are not consistent
>>> with the
>>> "initdb" output. The first one still uses "postgres -D", even mentions
>>> "check initdb output", but "initdb" emits "pg_ctl" commands.
>>>
>>> The attached patch updates the short install instructions and replaces
>>> "postgres -D" with "pg_ctl" calls.
>> Check.
>>
>>> diff --git a/doc/src/sgml/standalone-install.xml
>>> b/doc/src/sgml/standalone-install.xml
>>> index 62582effed..b5d2835a47 100644
>>> --- a/doc/src/sgml/standalone-install.xml
>>> +++ b/doc/src/sgml/standalone-install.xml
>>> @@ -50,7 +50,7 @@ in the stand-alone version.
>> That one though seems to be what's ending up in INSTALL, according to
>> the comment at the beginning of the file.
>>
>>>   <screen>root# <userinput>mkdir /usr/local/pgsql/data</userinput>
>>>   root# <userinput>chown postgres /usr/local/pgsql/data</userinput>
>>>   root# <userinput>su - postgres</userinput>
>>> -postgres$ <userinput>/usr/local/pgsql/bin/initdb -D
>>> /usr/local/pgsql/data</userinput></screen>
>>> +postgres$ <userinput>/usr/local/pgsql/bin/pg_ctl -D
>>> /usr/local/pgsql/data</userinput></screen>
>>>       </para>
>> I'm confused here, the paragraph reads "Create a database installation
>> with the <command>initdb</command>", so I think this hunk is not
>> correct and should be removed?
>
> That's indeed one replacement too much.
>
> The attached patch is fixing this.
>
>
>
>>> @@ -77,25 +77,21 @@ postgres$ <userinput>/usr/local/pgsql/bin/initdb
>>> -D /usr/local/pgsql/data</useri
>>>        The previous <command>initdb</command> step should have told
>>> you how to
>>>        start up the database server. Do so now. The command should look
>>>        something like:
>>> -<programlisting>/usr/local/pgsql/bin/postgres -D
>>> /usr/local/pgsql/data</programlisting>
>>> -     This will start the server in the foreground. To put the server
>>> -     in the background use something like:
>>> -<programlisting>nohup /usr/local/pgsql/bin/postgres -D
>>> /usr/local/pgsql/data \
>>> -    &lt;/dev/null &gt;&gt;server.log 2&gt;&amp;1 &lt;/dev/null
>>> &amp;</programlisting>
>>> +<programlisting>/usr/local/pgsql/bin/pg_ctl -D
>>> /usr/local/pgsql/data start</programlisting>
>>>       </para>
>>>         <para>
>>>        To stop a server running in the background you can type:
>>> -<programlisting>kill `cat
>>> /usr/local/pgsql/data/postmaster.pid`</programlisting>
>>> +<programlisting>/usr/local/pgsql/bin/pg_ctl -D
>>> /usr/local/pgsql/data stop</programlisting>
>>>       </para>
>>>      </step>
>>>        <step>
>>>       <para>
>>>        Create a database:
>>> -<screen><userinput>createdb testdb</userinput></screen>
>>> +<screen><userinput>/usr/local/pgsql/bin/createdb
>>> testdb</userinput></screen>
>>>        Then enter:
>>> -<screen><userinput>psql testdb</userinput></screen>
>>> +<screen><userinput>/usr/local/pgsql/bin/psql
>>> testdb</userinput></screen>
>>>        to connect to that database. At the prompt you can enter SQL
>>>        commands and start experimenting.
>>>       </para>
>> Check.
>
>
> Thank you for the review!
>

Submitted this to the Commitfest, and took the liberty to add you as a
reviewer.

Thanks,

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project