| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jacob Champion <jchampion(at)timescale(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs |
| Date: | 2023-06-30 07:42:13 |
| Message-ID: | 74D88F2C-48FD-422F-8F63-A02D10503A25@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 30 Jun 2023, at 09:09, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jun 29, 2023 at 09:05:59AM -0700, Jacob Champion wrote:
>> Sounds good -- 0002 can be ignored as needed, then. (Or I can resend a
>> v3 for CI purposes, if you'd like.)
>
> I am assuming that this is 0001 posted here:
> https://www.postgresql.org/message-id/8be3d35a-9608-b1d5-e5e6-7a744ea45fef@timescale.com
>
> And that looks OK to me. This is something I'd rather backpatch down
> to v11 on usability ground for developers. Any comments or objections
> about that?
Agreed, I'd prefer all branches to work the same for this.
Reading the patch, only one thing stood out:
-variable PG_TEST_NOCLEAN is set, data directories will be retained
-regardless of test status.
+variable PG_TEST_NOCLEAN is set, those directories will be retained
I would've written "the data directories" instead of "those directories" here.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiro Ikeda | 2023-06-30 08:29:17 | Re: PG 16 draft release notes ready |
| Previous Message | Jeff Davis | 2023-06-30 07:41:02 | Re: pgsql: Fix search_path to a safe value during maintenance operations. |