Re: psql and readline comments

From: Дилян Палаузов <dpa-postgres(at)aegee(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: psql and readline comments
Date: 2019-01-13 15:25:58
Message-ID: 7493dbdd54775b1160d7971039c575cab2b0e331.camel@aegee.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hello,

when the user does not set anything, the presumption is, that the system has reasonable defaults. A reasonable default
for “comment-begin” is “--”, and not the inherited default “#”.

Regards
Дилян

On Sun, 2019-01-13 at 10:08 -0500, Tom Lane wrote:
> =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= <dpa-postgres(at)aegee(dot)org> writes:
> > please consider integrating making the usual readilne binding M-# do in psql what users expect from it: insert comment
> > at the beginning of the line. See for patch:
> > https://www.postgresql.org/message-id/01e0355e-381e-9732-7d4e-cbd0e6bfa710@aegee.org
>
> I remain of the opinion that (1) nobody has tested the proposed patch
> across a range of readline and libedit versions, and (2) this would
> probably be better addressed by a documentation addition anyway.
> It's not psql's job to override user-settable readline options.
>
> regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Janes 2019-01-13 15:36:02 Re: BUG #15591: pg_receivewal does not honor replication slots
Previous Message Tom Lane 2019-01-13 15:08:18 Re: psql and readline comments