Re: make -C libpq check fails obscurely if tap tests are disabled

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: make -C libpq check fails obscurely if tap tests are disabled
Date: 2022-07-22 20:40:43
Message-ID: 748838.1658522443@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2022-Jul-22, Alvaro Herrera wrote:
>> It's not very common -- we do have some target-specific variable
>> assignments, but none of them use 'export'. I saw somewhere that this
>> works from Make 3.77 onwards, and we require 3.80, so it should be okay.
>> The buildfarm will tell us ...

> Hm, so prairiedog didn't like this:
> According to 32568(dot)1536241083(at)sss(dot)pgh(dot)pa(dot)us, prairiedog is on Make 3.80.

Yeah, it is. I looked at the gmake manual on that machine, and its
description of "export" seems about the same as what I see in a
modern version. So it should work ... but we've found bugs in 3.80
before.

Let me poke at it and see if there's a variant that works.
The wording of the message suggests that maybe breaking it into
two separate rules would help.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-07-22 20:40:48 Re: let's disallow ALTER ROLE bootstrap_superuser NOSUPERUSER
Previous Message Nathan Bossart 2022-07-22 20:37:35 predefined role(s) for VACUUM and ANALYZE