Re: [HACKERS] WIP: Covering + unique indexes.

> 29 нояб. 2017 г., в 8:45, Peter Geoghegan <pg(at)bowt(dot)ie> написал(а):
>
> On Tue, Nov 28, 2017 at 6:16 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Sun, Nov 12, 2017 at 8:40 PM, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>>> Postgres crashes:
>>> TRAP: FailedAssertion("!(((const void*)(&isNull) != ((void*)0)) && (scankey->sk_attno) > 0)", File: "nbtsearch.c", Line: 466)
>>>
>>> May be I'm doing something wrong or amcheck support will go with different patch?
>>
>> Usually amcheck complaining is a sign of other symptoms. I am marking
>> this patch as returned with feedback for now as no updates have been
>> provided after two weeks.
>
> It looks like amcheck needs to be patched -- a simple oversight.
> amcheck is probably calling _bt_compare() without realizing that
> internal pages don't have the extra attributes (just leaf pages,
> although they should also not participate in comparisons in respect of
> included/extra columns). There were changes to amcheck at one point in
> the past. That must have slipped through again. I don't think it's
> that complicated.
>

There is no doubts that this will be fixed. Therefor I propose move to next CF with Waiting for Author status.

Best regards, Andrey Borodin.