Re: logical replication and SIGHUP

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, peter(dot)eisentraut(at)2ndquadrant(dot)com, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: logical replication and SIGHUP
Date: 2017-04-10 14:03:46
Message-ID: 7439.1491833026@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
> On 10/04/17 14:40, Tom Lane wrote:
>> Umm ... you're doing what?

> We are doing:
> + SetConfigOption("synchronous_commit",
> + MySubscription->synccommit ?
> "local" : "off",
> + PGC_BACKEND, PGC_S_OVERRIDE);

That looks fine.

> I don't remember from top of my head if above is safe enough against
> config reread or not, hence the note.

Yes, the override will take care of it ...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-04-10 14:12:51 Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Previous Message Bruce Momjian 2017-04-10 13:44:16 Re: [HACKERS] Small issue in online devel documentation build