| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add missing period to DETAIL messages |
| Date: | 2026-04-09 08:00:10 |
| Message-ID: | 74359511-9F84-481E-B133-D2F68775D1CE@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Apr 9, 2026, at 12:27, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi,
>
> According to the error message style guide [1] "Detail and hint
> messages: Use complete sentences, and end each with a period."
>
> I found some DETAIL messages not following that period rule.
>
> PSA a patch that fixes the missing period. In passing, I also fixed
> some capitalization.
>
> ======
> [1] https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-GUIDE-GRAMMAR-PUNCTUATION
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
> <v1-0001-Add-missing-period-to-DETAIL-messages.patch>
```
- errdetail("password must be at least \"passwordcheck.min_password_length\" (%d) bytes long",
+ errdetail("password must be at least \"passwordcheck.min_password_length\" (%d) bytes long.ā,
```
First āpā should be capital.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2026-04-09 08:01:55 | Re: Upload only the failed tests logs to the Postgres CI (Cirrus CI) |
| Previous Message | Dapeng Wang | 2026-04-09 07:59:46 | Re: create table like including storage parameter |