Re: Keeping CURRENT_DATE and similar constructs in original format

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Keeping CURRENT_DATE and similar constructs in original format
Date: 2016-08-17 00:35:18
Message-ID: 7431.1471394118@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 5/12/16 6:14 PM, Tom Lane wrote:
>> So what I've wanted to do for some time is invent a new expression node
>> type that represents any one of these functions and can be reverse-listed
>> in the same format that the input had. The attached proposed patch does
>> that.

> I was experimenting with this as well when I found your patch, and I
> think this is the right solution. Your patch works fine for me.

Thanks for reviewing this patch. I've pushed it now.

>> (I'm not particularly in love with the node type name
>> ValueFunction; anybody got a better idea?)

> I think this is fine. The only other idea I have would be
> SQLValueFunction, to emphasize that this is about SQL-mandated special
> cases.

I went with SQLValueFunction.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-08-17 00:36:46 Re: Why we lost Uber as a user
Previous Message Jim Nasby 2016-08-17 00:03:22 Re: [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)