| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Switch opclass option functions to be STRICT (currently non-STRICT) |
| Date: | 2026-08-17 13:33:01 |
| Message-ID: | 740873.1786973581@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> However, if one looks at the internals of any of these functions, it
> is easy to note that they are not able to handle NULL inputs at all,
> leading to a crash (aka 8f7e35b08ad5). It looks like a mistake to me
> to declare them as not STRICT, while their internals are written to
> not be able to handle NULL.
Probably a mistake, but it's of no consequence. These all take
type internal so they can't be called from SQL; if they could be,
the hazards from passing a not-NULL pointer would be far worse
than what happens with a NULL. I can't get excited about doing
work to change it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Palak Chaturvedi | 2026-08-17 13:44:13 | Re: Make pg_prewarm, autoprewarm yield for waiting DDL |
| Previous Message | Jehan-Guillaume de Rorthais | 2026-08-17 13:32:14 | Re: Possible Visibility Map corruption in supported branches? |