From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |
Date: | 2021-01-26 07:57:39 |
Message-ID: | 73fc5ae4-3c54-1262-4533-f8c547de2e60@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021/01/26 16:39, Fujii Masao wrote:
>
>
> On 2021/01/26 16:33, Bharath Rupireddy wrote:
>> On Tue, Jan 26, 2021 at 12:54 PM Fujii Masao
>> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>> On 2021/01/26 16:05, Tom Lane wrote:
>>>> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>>>>> Thanks for the review! I fixed them and pushed the patch!
>>>>
>>>> Buildfarm is very not happy ...
>>>
>>> Yes.... I'm investigating that.
>>>
>>> -- Return false as connections are still in use, warnings are issued.
>>> SELECT postgres_fdw_disconnect_all();
>>> -WARNING: cannot close dropped server connection because it is still in use
>>> -WARNING: cannot close connection for server "loopback" because it is still in use
>>> WARNING: cannot close connection for server "loopback2" because it is still in use
>>> +WARNING: cannot close connection for server "loopback" because it is still in use
>>> +WARNING: cannot close dropped server connection because it is still in use
>>>
>>> The cause of the regression test failure is that the order of warning messages
>>> is not stable. So I'm thinking to set client_min_messages to ERROR temporarily
>>> when doing the above test.
>>
>> Looks like we do suppress warnings/notices by setting
>> client_min_messages to ERROR/WARNING. For instance, "suppress warning
>> that depends on wal_level" and "Suppress NOTICE messages when
>> users/groups don't exist".
>
> Yes, so I pushed that change to stabilize the regression test.
> Let's keep checking how the results of buildfarm members are changed.
+WARNING: roles created by regression test cases should have names starting with "regress_"
CREATE ROLE multi_conn_user2 SUPERUSER;
+WARNING: roles created by regression test cases should have names starting with "regress_"
Hmm... another failure happened.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-01-26 08:07:03 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |
Previous Message | Fujii Masao | 2021-01-26 07:39:54 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |