| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: run pgindent in CI |
| Date: | 2026-11-05 20:01:44 |
| Message-ID: | 73f06dac-1cf9-4e4c-9fdf-b690cea673ba@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.09.26 17:15, Peter Eisentraut wrote:
> On 23.09.26 16:35, Tom Lane wrote:
>> If we want to change that, then making CI bitch about non-ignored
>> files would be a good step, but it's incomplete unless the buildfarm
>> implementation enforces indent cleanliness the same way. IOW, what
>> I'm complaining about here is that what you want to do doesn't match
>> what koel does. They need to match.
>
> I have launched two new threads to prepare for this:
>
> pgindent to ignore build directories
> (https://www.postgresql.org/message-id/
> fc77b35a-34c4-4229-82f1-8cf0ce67f276%40eisentraut.org)
>
> convert CI CompilerWarnings job to meson
> (https://www.postgresql.org/message-id/e52e2c29-4834-4c64-a200-
> eddcba38fb4d%40eisentraut.org)
>
> When those are done, it will be possible to reproduce the koel
> environment on CI, and we can come back to this.
The above have been done, so here we are back on this.
I have adapted the workflow code to use meson now. I have also dropped
the github step summary display; the output (pgindent diff etc.) is now
just inline in the job logs. It's all pretty simple and straightforward
now.
I've kept the exclude_file_patterns patch here. I think we should still
apply this. As long as that file exists, we should keep it up to date,
and the patch was already written.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-XXX-misformatting-for-testing.patch | text/plain | 2.1 KB |
| v2-0003-Add-advisory-pgindent-check-to-CompilerWarnings-C.patch | text/plain | 3.6 KB |
| v2-0002-Add-missing-exclude_file_patterns.patch | text/plain | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2026-11-05 20:26:31 | Re: run pgindent in CI |
| Previous Message | Corey Huinker | 2026-11-05 19:48:18 | Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions |